Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vscode://file paths in the docs #6838

Closed
wants to merge 1 commit into from
Closed

Update vscode://file paths in the docs #6838

wants to merge 1 commit into from

Conversation

denis-sokolov
Copy link

@denis-sokolov denis-sokolov commented Nov 16, 2023

The syntax VS Code desires was recently clarified in a comment: microsoft/vscode#197319 (comment)

This commit aligns the documentation with that comment.

To be clear, I am not in favor of this change, the new syntax looks misleading and there is a needless dichotomy between Windows and other versions. But as per the answer in the other issue, this is currently the right way to invoke VS Code.

The syntax VSCode desires was recently clarified in a comment:
microsoft/vscode#197319 (comment)

This commit aligns the documentation with that comment.
@andrewnicols
Copy link

Pinging @bpasero for this in relation to microsoft/vscode#197319

@bpasero
Copy link
Member

bpasero commented Nov 17, 2023

How about just removing the generic links and only provide examples so that its clear how to use the links?

@denis-sokolov
Copy link
Author

It seems like with the latest change we don’t necessarily need any change in the docs. I’ll close this for cleanup, but if anyone decides to iterate, you can freely use my original suggestion if need be.

@denis-sokolov denis-sokolov deleted the patch-1 branch November 17, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants